Addition of HEPMC3 and GENIE Reweight to docker image #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ketchum_HEPMC3
|
Saw two errors from running ctest: |
This was referenced Oct 16, 2024
There was a problem hiding this comment.
I do not know why there is a seg fault on the first event. I'm curious if it happens outside of ctest and if it does, then I'd do a Debug build of ldmx-sw and run the config in gdb to try to find the culprit.
Besides my question on Pythia6, I feel obliged to point out the OS update in the pipeline: #103 This would presumably require re-development of these changes, although that OS update also requires updates to ldmx-sw.
| @@ -214,6 +247,7 @@ RUN mkdir src &&\ | |||
| -Dxrootd=OFF \ | |||
| -Dgsl_shared=ON \ | |||
| -Dmathmore=ON \ | |||
| -Dpythia8=ON \ | |||
| -Dpythia6=ON \ | |||
There was a problem hiding this comment.
Can we remove Pythia6? Is it still necessary?
There was a problem hiding this comment.
Unfortunately still necessary :/ I know the GENIE team is working on it, but I think the Pythia6 dependency is buried deep, and they've not fully extricated it yet. I will double-check to be sure, but unfortunately it's a case where it looks like we need both.
|
Thanks @tomeichlersmith. I haven't had the chance to investigate the test failure in more detail yet, but will do so. Good to verify that they should not be failing. I'll review the OS updates as well and work to make sure we have the right plan for that. |
|
OK, with a fresh environment / pulling down ldmx-sw trunk, I can properly build with the docker container and the ctests pass: Working on the various |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the addition of the HEPMC3 package, addition of Pythia8 for future interfaces to GENIE, updates to GENIE to include interfaces to HEPMC3, and the inclusion of the GENIE Reweight package.
What new packages does this PR add to the development container?
Check List
Following the above instructions, I saw two errors. Will include in following message.
Executed updated GENIE simulation and reweighting (from branch
wketchum/Genie_Generator_HepMC3Refactorin ldmx-sw) and verified all appears to be working well.